This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add CI/CD workflows #133
Merged
Add CI/CD workflows #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds CI/CD workflows. CI workflow builds a zip file, installs that on the official odfe docker image, and runs rest test case. CI workflow is triggered via branch pushing. CD workflow builds zip, rpm, deb files and uploads those files to s3. CD workflow is triggered via tag creation. This PR also increases model initialization waiting time as needed on an rest test case as that time can be can be longer on a remote cluster. Testing done: 1. run the scripts on CI/CD workflow on Mac and tested it works. 2. make sure local gradle build time does not increase.
wnbts
reviewed
May 22, 2020
| // we wait at most 60 secs | ||
| if (duration < 60_000) { | ||
| Thread.sleep(2_000); | ||
| } else { |
There was a problem hiding this comment.
if it is timed out, is it better to fail fast?
There was a problem hiding this comment.
yeah, changed to throw exception.
| @@ -172,7 +172,22 @@ private void startDetector( | |||
| } catch (Exception e) {} | |||
| } | |||
| Thread.sleep(5_000); | |||
There was a problem hiding this comment.
this wait can be merged to the wait below now
.github/workflows/CI.yml
Outdated
| - name: Run AD Test | ||
| run: | | ||
| ./gradlew ':integTestRunner' --tests "com.amazon.opendistroforelasticsearch.ad.rest.*IT" -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername="docker-cluster" | ||
| ./gradlew :integTestRunner --tests "com.amazon.opendistroforelasticsearch.ad.e2e.*IT" -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername="docker-cluster" |
There was a problem hiding this comment.
This won't run if the first one fails. just wanna confirm if this is what we expect
There was a problem hiding this comment.
good point. Merged these 2 lines into one.
wnbts
approved these changes
May 26, 2020
weicongs-amazon
approved these changes
May 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#104
Description of changes:
This PR adds CI/CD workflows. CI workflow builds a zip file, installs that on the official ODFE docker image, and runs rest test case. CI workflow is triggered by branch pushing. CD workflow builds zip, rpm, deb files, and uploads those files to s3. CD workflow is triggered by tag creation.
This PR also increases model initialization waiting time as needed on DetectionResultEvalutationIT as it can be long on a remote cluster.
Testing done:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.